Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GenericPatternItemULE::as_pattern_item_ule #4497

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Add GenericPatternItemULE::as_pattern_item_ule #4497

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f02346
Add as_pattern_item_ule
sffc Dec 27, 2023
54857bb
Revert unrelated changes
sffc Dec 27, 2023
cde1a5b
More docs
sffc Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions components/datetime/src/pattern/item/ule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ use zerovec::ule::{AsULE, ZeroVecError, ULE};
///
/// If the discriminant is not set, the bottom three bits of the first byte,
/// together with the next two bytes, contain all 21 bits required to encode
/// any [`Unicode Code Point`].
/// any [`Unicode Code Point`]. By design, the representation of a code point
/// is the same between [`PatternItemULE`] and [`GenericPatternItemULE`].
///
/// # Diagram
///
Expand Down Expand Up @@ -160,7 +161,8 @@ impl AsULE for PatternItem {
///
/// If the discriminant is not set, the bottom three bits of the first byte,
/// together with the next two bytes, contain all 21 bits required to encode
/// any [`Unicode Code Point`].
/// any [`Unicode Code Point`]. By design, the representation of a code point
/// is the same between [`PatternItemULE`] and [`GenericPatternItemULE`].
///
/// # Diagram
///
Expand Down Expand Up @@ -215,6 +217,28 @@ impl GenericPatternItemULE {
char::try_from(u).is_ok()
}
}

/// Converts this [`GenericPatternItemULE`] to a [`PatternItemULE`]
/// (if a Literal) or returns the placeholder value.
#[allow(dead_code)] // #4415
#[inline]
pub(crate) fn as_pattern_item_ule(&self) -> Result<&PatternItemULE, u8> {
if Self::determine_field_from_u8(self.0[0]) {
Err(self.0[2])
} else {
if cfg!(debug_assertions) {
let GenericPatternItem::Literal(c) = GenericPatternItem::from_unaligned(*self)
else {
unreachable!("expected a literal!")
};
let pattern_item_ule = PatternItem::Literal(c).to_unaligned();
debug_assert_eq!(self.0, pattern_item_ule.0);
}
// Safety: when a Literal, the two ULEs have the same repr,
// as shown in the above assertion (and the class docs).
Ok(unsafe { core::mem::transmute(self) })
}
}
}

// Safety (based on the safety checklist on the ULE trait):
Expand Down