-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fancy new keviyah module for Hebrew calendrical calculations #4504
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
94e12ea
Improve Date's debug impl
Manishearth 93cb820
Add conversiomn bench for hebrew
Manishearth ae80409
Functions for getting YearInfo from Keviyah, computing the year that …
Manishearth 8d3931b
Add month length code
Manishearth 127d50e
inline
Manishearth b805dde
Plug keviyah into hebrew calendar impl
Manishearth 55c8256
fixes
Manishearth 8050924
Add month_day_for(), cleanup
Manishearth 3b8a6c4
clippy
Manishearth fdbb0cb
test
Manishearth 1a9ed56
Update utils/calendrical_calculations/src/hebrew_keviyah.rs
Manishearth 201b4b9
Better length correction APIs
Manishearth 1bc5496
saturate
Manishearth bebd22a
Clamp to min/max r.d.
Manishearth 88f11b1
Write days_preceding as match statement
Manishearth 9e01978
clip
Manishearth 162011e
Add normalized month constants
Manishearth 2782bae
Remove all book code
Manishearth d8013c1
Use consistent spelling of month names
Manishearth c3aefa5
merge table
Manishearth 0325fb7
test ordinal construction
Manishearth 6b63138
make table uniform
Manishearth 81c1e70
clippy
Manishearth fb1ce60
pubcrate
Manishearth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can you debug-assert that
info
is the correct info foryear
? That's an invariant of CalendarArithmetic that isn't being enforced in this constructor as far as I see.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. In the long term I want CalendarArithmetic's methods to always take
ArithmeticDate
(even though it means in some cases we'll need to make fake dates)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this isn't possible to do; CalendarArithmetic doesn't know anything about YearInfo.