Fix datagen to propagate extension keywords and aux keys to child locales #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
sffc
added
T-bug
Manishearth
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Overall looks good but I want to defer to @robertbastian on final review
provider/datagen/src/driver.rs
Outdated
| /// Resolves the set of explicit langids and the supported locales into two sets of locales: | ||
| /// | ||
| /// - `explicit` contains the explicit langids but with aux keys and extension keywords included | ||
| /// - `implcit` contains any locale reachable by fallback from an `explicit` locale |
There was a problem hiding this comment.
nit: I'd like more comments here to explain what this handles, with examples referencing the locales mentioned in comments below
robertbastian
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4488
If
ar-SAis requested andar-u-nu-latnexists,ar-SA-u-nu-latnshould be included, even if that locale isn't in CLDR data by itself.This shows up also in the experimental skeleton keys. CC @blaynem
It also impacts neo datetime because of aux keys.