Add ZeroAsciiIgnoreCaseTrieCursor #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c: u8, | ||
| ) -> Option<u8> { | ||
| // BinarySpans is tricky to implement because the state can no longer be simply a trie | ||
| debug_assert!( |
There was a problem hiding this comment.
Should this return None here without assertions?
There was a problem hiding this comment.
Without assertions it returns None on line 468, if it actually hits a span node.
There was a problem hiding this comment.
There's already a debug assert there, why this as well? There should at least be a comment linking to the line and what the gigo value is.
| /// For examples, see [`ZeroAsciiIgnoreCaseTrie::cursor()`]. | ||
| // Clone but not Copy: <https://stackoverflow.com/q/32324251/1407170> | ||
| #[derive(Debug, Clone)] | ||
| pub struct ZeroAsciiIgnoreCaseTrieCursor<'a> { |
There was a problem hiding this comment.
not a big fan of adding yet another type, but you already know that
There was a problem hiding this comment.
I wrote some ideas on how to resolve this in #4561
robertbastian
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last piece of the ZeroTrie improvements required to continue work on #4548 / #4031
I filed #4561 for additional follow-up work to try to reduce code duplication. I would like to not block this PR on code duplication concerns.