Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark BidiClassAdapter::new as const #4584

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Mark BidiClassAdapter::new as const #4584

merged 3 commits into from
Feb 5, 2024

Conversation

vgskye
Copy link
Contributor

@vgskye vgskye commented Feb 5, 2024

Marks the new associated function for icu_properties::bidi::BidiClassAdapter as const. This allows a BidiClassAdapter to be constructed in const context with a data source available in const context, such as the data bundled using compiled_data. as unicode-bidi takes a reference to the BidiDataSource, this allows the same BidiDataSource to be used throughout the program and simplifies the lifetimes.

@vgskye vgskye requested a review from a team as a code owner February 5, 2024 12:27
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

robertbastian
robertbastian approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertbastian robertbastian merged commit 2e188b0 into unicode-org:main Feb 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgskye @CLAassistant @robertbastian