Update sentence segmenter rules to Unicode 15.1 #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makotokato
requested review from
sffc,
robertbastian,
Manishearth,
aethanyc and
a team
as code owners
robertbastian
approved these changes
Feb 22, 2024
Manishearth
approved these changes
Feb 22, 2024
|
Oh wait this removed monkey tests. @eggrobin does this seem correct? |
Makoto regenerated a new batch of monkeys in a new file; looks like it is from a fork of ICU; in principle it should be doable from unicode-org main right now since I finally merged the monkey exporter, but this is fine. |
aethanyc
added a commit
to aethanyc/icu4x
that referenced
this pull request
Mar 20, 2024
We've updated sentence segmenter to 15.1 in unicode-org#4625 and grapheme cluster segmenter in unicode-org#4536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sentence segmenter rules to Unicode 15.1.
Monkey tests are incompatible with Unicode 15.1. So I generate this test data using ICU4C 74.2.