Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 2820-year with 33-year cycle in Persian calendar #4775

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Replace 2820-year with 33-year cycle in Persian calendar #4775

merged 4 commits into from
Apr 11, 2024

Conversation

roozbehp
Copy link
Contributor

@roozbehp roozbehp commented Apr 5, 2024 •
edited
Loading

Partial fix for #4713

@roozbehp roozbehp requested review from Manishearth, sffc and a team as code owners April 5, 2024 12:30
Manishearth
Manishearth previously approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to resurrect the old code myself if you don't want to

thanks so much!!

utils/calendrical_calculations/src/persian.rs Show resolved Hide resolved
@roozbehp
Copy link
Contributor Author

roozbehp commented Apr 6, 2024

happy to resurrect the old code myself if you don't want to

thanks so much!!

Resurrected. PTAL.

Manishearth
Manishearth previously approved these changes Apr 6, 2024
View reviewed changes
@roozbehp
Copy link
Contributor Author

roozbehp commented Apr 6, 2024

Looks like I don't have authorization to merge this. Please merge yourself.

@Manishearth
Copy link
Member

Yep, I will once Shane reviews it

Manishearth
Manishearth previously approved these changes Apr 8, 2024
View reviewed changes
sffc
sffc previously approved these changes Apr 11, 2024
View reviewed changes
components/calendar/src/persian.rs Show resolved Hide resolved
utils/calendrical_calculations/src/persian.rs Outdated Show resolved Hide resolved
utils/calendrical_calculations/src/persian.rs Outdated Show resolved Hide resolved
@roozbehp roozbehp dismissed stale reviews from sffc and Manishearth via 66da7a0 April 11, 2024 02:02
@roozbehp
Copy link
Contributor Author

PTAL.

@sffc sffc merged commit 75cb5b6 into unicode-org:main Apr 11, 2024
30 checks passed
@roozbehp roozbehp deleted the roozbehp-persian-cal branch April 11, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roozbehp @Manishearth @sffc