Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR 45 #4782

Merged
merged 14 commits into from
May 6, 2024
Merged

CLDR 45 #4782

merged 14 commits into from
May 6, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Apr 8, 2024

Fixes #4648

@robertbastian robertbastian changed the title [WIP] CLDR 45 CLDR 45 Apr 17, 2024
@robertbastian robertbastian marked this pull request as ready for review April 17, 2024 17:51
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Manishearth
Manishearth previously approved these changes Apr 24, 2024
Manishearth
Manishearth previously approved these changes Apr 30, 2024
@robertbastian
Copy link
Member Author

I've updated to the dictionaries generated in unicode-org/icu#2988, and the diffs are gone. CI will fail until the published zip file is patched.

@robertbastian robertbastian requested a review from sffc May 3, 2024 15:12
Manishearth
Manishearth previously approved these changes May 3, 2024
@sffc
Copy link
Member

sffc commented May 3, 2024

Progress on updating icuexportdata.zip:

  1. ICU-22764 Fix gendict memory safety in toml uchars mode icu#2988 is merged
  2. ICU-22764 Fix gendict memory safety in toml uchars mode icu#2995 needs to be merged after CI passes
  3. An icu4x integration tag needs to be made from that new commit with the zip file uploaded
  4. This PR should be updated to use that new tag
  5. The zip file on the release-75-1 tag should be replaced with the new zip file. We won't use it in ICU4X directly, but it can prevent bugs if people build ICU4X data from that tag.

@robertbastian
Copy link
Member Author

The zip file on the release-75-1 tag should be replaced with the new zip file. We won't use it in ICU4X directly, but it can prevent bugs if people build ICU4X data from that tag.

I would like to use the release-75-1 tag. This is visible to users, both through the constant, as well as through the metadata written into baked data. It's not clear whether there's a data diff between icu4x/2024-05-03/75.x and release-75-1

@sffc
Copy link
Member

sffc commented May 6, 2024

@robertbastian Can you fix the diff please?

@robertbastian
Copy link
Member Author

Done

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer using "icu4x/2024-05-03/75.1" but I won't block on that

@robertbastian robertbastian merged commit 59bb67e into unicode-org:main May 6, 2024
30 checks passed
@robertbastian robertbastian deleted the 45 branch May 7, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ICU4X to Unicode 16, CLDR 45
3 participants