Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create BoundProvider, NeoFormatter, and TypedNeoFormatter #4877

Merged
merged 31 commits into from
May 9, 2024
Merged

Create BoundProvider, NeoFormatter, and TypedNeoFormatter #4877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
6c73bc6
Add initial empty marker trait for DateTimeNames
sffc May 7, 2024
3efbbd1
Working WeekdayNames assoc type
sffc May 7, 2024
24b30bd
Move for<'a> to the right place
sffc May 7, 2024
76d9bd4
Reveal the impact to neo_time_formatter_size
sffc May 7, 2024
14c443b
DayPeriod treatment
sffc May 7, 2024
ff377f7
Year and Month treatment
sffc May 7, 2024
90d936e
TypeTooNarrow error
sffc May 7, 2024
420f865
Checkpoint: TypedNeoFormatter
sffc May 8, 2024
ea246e8
TypedNeoFormatter is passing tests
sffc May 8, 2024
007ec24
Refactor / generalize NeoSkeleton traits to prepare for AnyCalendar
sffc May 8, 2024
08d7d7a
Mostly compiling AnyCalendar formatter
sffc May 8, 2024
95282ea
Add missing std pointer-like impls for DataProvider, DynamicDataProvider
sffc May 8, 2024
ccd9c17
Improving abstractions to collapse an error case
sffc May 8, 2024
a5a9233
Create BoundDataProvider
sffc May 8, 2024
e4c2ca1
Switch to using BoundDataProvider
sffc May 8, 2024
abb3ffa
Migrate the other keys to BoundDataProvider
sffc May 8, 2024
db8f0f9
Progress on AnyCalendarProvider
sffc May 8, 2024
970f861
AnyCalendarProvider4
sffc May 8, 2024
ac49bd7
Progress
sffc May 8, 2024
9bbe2bb
Progress
sffc May 8, 2024
93ef6db
Phew, AnyCalendar skeleta NeoFormatter working
sffc May 8, 2024
cc8bd95
Consolidate traits
sffc May 9, 2024
f48c07f
Cleanup
sffc May 9, 2024
4da1935
Merge branch 'main' into datetimenames-marker
sffc May 9, 2024
4c4d95c
Features
sffc May 9, 2024
8af5d3c
Add TODOs
sffc May 9, 2024
b3b16fd
Clippy, feedback
sffc May 9, 2024
4ac6ec2
Docs links
sffc May 9, 2024
639c250
fmt
sffc May 9, 2024
aa101c7
CHANGELOG
sffc May 9, 2024
2be79e3
Add extra comment about use case for BoundDataProvider
sffc May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
- `icu_provider`
- (Small breakage) `DataPayload::new_owned()` is no longer `const`, this was a mistake (https://github.com/unicode-org/icu4x/pull/4456)
- Add `NeverMarker` to allow for DataProvider bounds that never return data (https://github.com/unicode-org/icu4x/issues/4186)
- Add `BoundProvider` to allow temporal separation between key and request (https://github.com/unicode-org/icu4x/pull/4877)
- `icu_provider_blob`
- Blob v2 no longer allocates (https://github.com/unicode-org/icu4x/pull/4383)
- FFI:
Expand Down
358 changes: 222 additions & 136 deletions components/datetime/src/calendar.rs
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading