Create BoundDataProvider, a DataProvider that always loads for the same key #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
sffc
commented
May 8, 2024
| @@ -84,6 +84,15 @@ pub trait DataMarker: 'static { | |||
| pub trait KeyedDataMarker: DataMarker { | |||
| /// The single [`DataKey`] associated with this marker. | |||
| const KEY: DataKey; | |||
|
|
|||
| /// Binds this [`KeyedDataMarker`] to a provider supporting it. | |||
| fn bind<P>(provider: P) -> DataProviderWithKey<Self, P> | |||
There was a problem hiding this comment.
I added this helper function because type inference works better at the call site. Instead of doing
DataProviderWithKey::<MyDataMarkerV1, _>::new(provider)I can just write
MyDataMarkerV1::bind(provider)
sffc
commented
May 9, 2024
| /// Unlike [`DataProvider`], the provider is bound to a specific key ahead of time. | ||
| /// | ||
| /// [`AnyMarker`]: crate::any::AnyMarker | ||
| pub trait BoundDataProvider<M> |
There was a problem hiding this comment.
@Manishearth suggests documenting the purpose for the type.
|
Without objections I will just merge this as part of #4877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this type of abstraction in DateTimeFormatter. I realized that this is a more useful abstraction in practice than
DynamicDataProvider. I created a ticket to deleteDynamicDataProviderin 2.0. #4881Includes #4880