Inline no_major_solar_term into call sites to reduce duplicate work #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
May 22, 2024
| let solar_term_a = major_solar_term_from_fixed::<C>(month_after_eleventh); | ||
| let solar_term_b = major_solar_term_from_fixed::<C>(month_after_twelfth); | ||
| let solar_term_c = major_solar_term_from_fixed::<C>(month_after_thirteenth); | ||
| if lhs_argument == 12 && (solar_term_a == solar_term_b || solar_term_b == solar_term_c) { |
There was a problem hiding this comment.
nit: mention in a comment that this is where the inlining of no_major_solar_term has happened so it's easier to compare algorithms
There was a problem hiding this comment.
The inlining impacts the whole function because in addition to inlining no_major_solar_term, I'm also pre-calculating month_after_thirteenth, which was being calculated previously by no_major_solar_term and then again by this function. I'm not sure of the correct way to phrase an additional comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4904. This is a productive standalone change.