Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up #4985 #4995

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Follow-up #4985 #4995

merged 2 commits into from
Jun 3, 2024

Conversation

robertbastian
Copy link
Member

No description provided.

sffc
sffc previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a beneficial change. We'll probably need to change it again when we iterate on IterableDataProvider.

provider/datagen/src/provider.rs Outdated Show resolved Hide resolved
Manishearth
Manishearth previously approved these changes Jun 3, 2024
View reviewed changes
@robertbastian robertbastian dismissed stale reviews from Manishearth and sffc via 6c86a52 June 3, 2024 21:45
@robertbastian robertbastian requested a review from sffc June 3, 2024 21:45
@robertbastian robertbastian mentioned this pull request Jun 3, 2024
Closed
@robertbastian robertbastian merged commit 24761aa into unicode-org:main Jun 3, 2024
28 checks passed
@robertbastian robertbastian deleted the cache branch June 3, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Manishearth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth