Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(LanguageIdentifier): Derive PartialOrd and Ord for LanguageIdentifier. #5295

Closed
wants to merge 2 commits into from
Closed

refactor(LanguageIdentifier): Derive PartialOrd and Ord for LanguageIdentifier. #5295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14e5274
refactor(LanguageIdentifier): Derive 'PartialOrd' and 'Ord' for type.
JosiahBull Jul 25, 2024
45cab55
doc: update CHANGELOG.md.
JosiahBull Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# Changelog

## icu4x 1.5.x
## icu4x Unreleased

- Components
- General
- `PartialOrd` and `Ord` derived for `LanguageIdentifier`.

## icu4x 1.5.x

- `icu_calendar`
- (1.5.1) Fix Japanese calendar Gregorian era year 0 (https://github.com/unicode-org/icu4x/issues/4968)
Expand Down
2 changes: 1 addition & 1 deletion components/locale_core/src/langid.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ use writeable::Writeable;
/// ```
///
/// [`Unicode BCP47 Language Identifier`]: https://unicode.org/reports/tr35/tr35.html#Unicode_language_identifier
#[derive(Default, PartialEq, Eq, Clone, Hash)]
#[derive(Default, PartialEq, Eq, Clone, Hash, PartialOrd, Ord)]
#[allow(clippy::exhaustive_structs)] // This struct is stable (and invoked by a macro)
pub struct LanguageIdentifier {
/// Language subtag of the language identifier.
Expand Down