Use LikelySubtagsForLanguageV1
for fallback
#5338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LikelySubtagsForLanguageV1
is almost identical toLocaleFallbackLikelySubtagsV1
, the differences being:LikelySubtagsForLanguageV1
contains aund
field, which is not needed for fallbackLocaleFallbackLikelySubtagsV1
usesZeroMap2d
s, whereasLikelySubtagsForLanguageV1
usesZeroMap
s with tuple keys. Fallback always looks up by both keys at the same time, so theZeroMap2d
overhead is unnecessary.LocaleFallbackLikelySubtagsV1
omits Language->Script entries where the script isLatn
. While this might save a few bytes, I'm not sure that it's correct, as fallback for unknown languages will assume that they are Latin and strip theLatn
subtag during normalisation.The
ZeroMap2d
overhead seems to cancel out theund
field andLatn
optimisation, andLikelySubtagsForLanguageV1
is only two bytes bigger thanLocaleFallbackLikelySubtagsV1
(2230B vs 2228B).