Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust to 1.71.1 #5484

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Update rust to 1.71.1 #5484

merged 4 commits into from
Sep 3, 2024

Conversation

Manishearth
Copy link
Member

Needed by pulldown_cmark v12, pulled in by the Diplomat upgrade (#5482). This is a diplomat-tool dep and not user-facing, but our CI is set up in a way that that trips our MSRV check. We could exclude the diplomat regen crate from that CI job.

Current Rust stable is 1.80.1, by policy:

One may update the MSRV to a Rust version that is 6 or more versions before the current stable (or the stable version that shall exist at the time of the next ICU4X release if it is planned) without needing additional approval by stating which features in that release are useful for ICU4X development. One may not update the MSRV to a Rust version that is not at least 4 versions before current stable.

We do not need further justification according to policy, though we don't actually really need any features from there either.

@Manishearth Manishearth requested review from sffc and a team as code owners September 3, 2024 21:50
@Manishearth Manishearth mentioned this pull request Sep 3, 2024
@Manishearth Manishearth merged commit 66af677 into unicode-org:main Sep 3, 2024
28 checks passed
@Manishearth Manishearth deleted the rustup branch September 3, 2024 22:11
sffc pushed a commit that referenced this pull request Sep 3, 2024
For #5482 and
#5484, I have to update
segmenter's generated code due to
#5318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants