Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SourceInfo option to the data export #5506

Closed
wants to merge 2 commits into from
Closed

Add SourceInfo option to the data export #5506

wants to merge 2 commits into from

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 5, 2024

See #58

@sffc sffc mentioned this pull request Sep 5, 2024
Open
Manishearth
Manishearth approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, and I like that it's optional, so if we're doing a lot of tiny blobs for fine grained loading, we don't have to include this bit.

@sffc
Copy link
Member Author

sffc commented Sep 23, 2024

Made obsolete by #5544

@sffc sffc closed this Sep 23, 2024
@sffc sffc deleted the with-source-info branch September 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@robertbastian robertbastian Awaiting requested review from robertbastian robertbastian will be requested when the pull request is marked ready for review robertbastian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sffc @Manishearth