Update locale_core::preferences to stakeholder alignment #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbraniecki
force-pushed
the
prefs_2
branch
4 times, most recently
from
bed1d48 to
9bcc486
Compare
|
@sffc @robertbastian - can I get a high level thumbs up on that direction? |
|
Looks like what we agreed on |
|
Added list format - @sffc @robertbastian - PTAL. If you're good with that, I'll document it and we're gtg |
zbraniecki
force-pushed
the
prefs_2
branch
3 times, most recently
from
37921e8 to
0dab081
Compare
sffc
reviewed
Oct 29, 2024
There was a problem hiding this comment.
ListFormatterPreferences seems about right.
As written in a comment, I don't really see switching around how we do options right now. I guess it generates merge functions, which is nice, but can't we add those on later?
I also don't agree with changing all constructors to use options bags just because they can. The ones that don't take options bags use positional arguments instead and are named _with_foo or _with_foo_and_bar. That seems fine to me.
zbraniecki
requested review from
sffc,
robertbastian and
filmil
and removed request for
filmil
zbraniecki
force-pushed
the
prefs_2
branch
3 times, most recently
from
95105d4 to
377185d
Compare
zbraniecki
requested review from
Manishearth,
filmil,
nciric and
a team
as code owners
zbraniecki
force-pushed
the
prefs_2
branch
2 times, most recently
from
69606a3 to
3ea2a5e
Compare
components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs
Outdated
Show resolved
Hide resolved
components/locale_core/src/preferences/extensions/unicode/macros/mod.rs
Outdated
Show resolved
Hide resolved
sffc
reviewed
Nov 5, 2024
components/locale_core/src/preferences/extensions/unicode/keywords/numbering_system.rs
Outdated
Show resolved
Hide resolved
Manishearth
pushed a commit
that referenced
this pull request
Nov 5, 2024
robertbastian
approved these changes
Nov 6, 2024
sffc
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #419 feedback