Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DeserializeSkeletonBincode with one less branch #582

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Simplify DeserializeSkeletonBincode with one less branch #582

merged 1 commit into from
Mar 31, 2021

Conversation

gregtatum
Copy link
Member

This is a fast follow for #480 – #480 (comment)

@gregtatum gregtatum requested a review from sffc March 29, 2021 14:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build d76541242e93b43827fdb7bcfab1dfabac83c1c4-PR-582

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 73.141%
Files with Coverage Reduction New Missed Lines %
components/provider_ppucd/src/parse_ppucd.rs 1 93.0%
Totals Coverage Status
Change from base Build 19642c3500fe5ca50c7acbba82d33fc572ec0513: -0.01%
Covered Lines: 6266
Relevant Lines: 8567
💛 - Coveralls

sffc
sffc approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@gregtatum gregtatum merged commit 6991943 into unicode-org:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregtatum @coveralls @zbraniecki @sffc