More DateTime renames #5838
Merged
More DateTime renames #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
sffc
force-pushed
the
more-dt-renames
branch
from
a43f745
to
860c55f
Compare
sffc
force-pushed
the
more-dt-renames
branch
from
faee142
to
a230ac9
Compare
|
I think this is reviewable commit by commit if you prefer |
|
@Manishearth Please verify that you are reasonably happy with the |
sffc
commented
Nov 19, 2024
Comment on lines
+139
to
+145
| /// | ||
| /// // To make the error occur sooner, one can use an EmptyDataProvider: | ||
| /// let empty = EmptyDataProvider::new(); | ||
| /// assert!(matches!( | ||
| /// names.load_for_pattern(&empty, &pattern), | ||
| /// Err(PatternLoadError::Data(_, Field { symbol: FieldSymbol::Weekday(_), .. })), | ||
| /// )); |
There was a problem hiding this comment.
Highlighting the new doc example here, the one that resolves #5840
Manishearth
approved these changes
Nov 19, 2024
Manishearth
reviewed
Nov 19, 2024
| @@ -13,14 +13,14 @@ size_test!(DateTimePattern, date_time_pattern_size, 32); | |||
|
|
|||
| /// A pattern for formatting a datetime in a calendar. | |||
| /// | |||
| /// [`DateTimePattern`] forgoes most internationalization functionality of the datetime crate. | |||
| /// ❗ This type forgoes most internationalization functionality of the datetime crate. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5836
Fixes #5840