Remove type fallback from datagen #6115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Feb 14, 2025
There was a problem hiding this comment.
A bit annoying that you need to check extra data structs to get the name you need, but the size win is compelling.
I can follow the fallback chain when it is illustrated.
Seems likely that bugs will arise with all this fallbacking; make sure it is well tested.
Comment on lines
+167
to
+169
| MetazoneGenericStandardNamesLongV1, | ||
| "time_zone/generic_standard_long@1", | ||
| has_checksum |
There was a problem hiding this comment.
Suggestion: Maybe name it metazone/standard/names/long/v1 (on the same level as generic and standard)?
provider/source/data/debug/datetime/MetazoneSpecificNamesLongV1/en.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falling back from the
genericto thestandarddisplay name for the generic format in datagen means thestandarddisplay name will be included in both generic and specific data structs.This introduces a second "generic standard" data struct that contains generic names that are actually standard. This data struct is used by both the generic and the specific format.