Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook tlb fill #2037

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Hook tlb fill #2037

merged 2 commits into from
Oct 18, 2024

Conversation

elicn
Copy link
Contributor

@elicn elicn commented Oct 18, 2024

Highlights:

Notes:

  • Requires sanity testing
  • Requires unit testing

@wtdcode wtdcode merged commit 28ff8d8 into unicorn-engine:dev Oct 18, 2024
36 checks passed
@wtdcode
Copy link
Member

wtdcode commented Oct 18, 2024

Thanks!

@elicn elicn deleted the hook-tlb-fill branch October 19, 2024 19:57
DynamicLoader
DynamicLoader reviewed Oct 22, 2024
View reviewed changes
bindings/python/unicorn/unicorn_py3/unicorn.py
def __hok_tlb_fill():
@uccallback(self, HOOK_TLB_FILL_CFUNC)
def __hook_tlb_fill_cb(uc: Uc, vaddr: int, access: int, entry: ctypes._Pointer[uc_tlb_entry], key: int):
callback(uc, vaddr, access, entry.contents, user_data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return it since the return value is bool, not void.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you are correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that in #2042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DynamicLoader DynamicLoader DynamicLoader left review comments

@wtdcode wtdcode wtdcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elicn @wtdcode @DynamicLoader