Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request for Issue #364: Invalidating Translation Cache after self-modifying code #408

Merged
merged 2 commits into from
Jan 31, 2016
Merged

Pull Request for Issue #364: Invalidating Translation Cache after self-modifying code #408

merged 2 commits into from
Jan 31, 2016

Conversation

egberts
Copy link
Contributor

@egberts egberts commented Jan 31, 2016

It's done...

egberts and others added 2 commits January 22, 2016 07:51
@egberts
Merge pull request #1 from unicorn-engine/master
a556c3c 
Test pull into my fork
Issue unicorn-engine#364 - Move RIP/PC closer next to the offending s…
fc22a35 
…elf-modifying code

which modified the 2nd next instruction (imul) in which that escaped
our wonderful ability to invalidate the
instruction translation cache in which we badly need to pick up the
self-modification being made.
aquynh added a commit that referenced this pull request Jan 31, 2016
@aquynh
Merge pull request #408 from egberts/master
a5020c6 
Pull Request for Issue #364: Invalidating Translation Cache after self-modifying code
@aquynh aquynh merged commit a5020c6 into unicorn-engine:master Jan 31, 2016
@aquynh
Copy link
Member

aquynh commented Jan 31, 2016

merged, thanks!

@egberts
Copy link
Contributor Author

egberts commented Jan 31, 2016

Whoohoo! Getting the hang of Git merge, particularly Github merge.

@aquynh
Copy link
Member

aquynh commented Jan 31, 2016

you don't need to call uc_hook_add() separately for different type of memory accesses, but can combine them. see 1fb5416

to make it easier, i added a new hook type UC_HOOK_MEM_VALID at a2ef521

and your testcase can use it now: 32b9dec

will look closer into this issue now.

@egberts
Copy link
Contributor Author

egberts commented Feb 3, 2016

ping. :-(

@aquynh
Copy link
Member

aquynh commented Feb 3, 2016 via email

@egberts
Copy link
Contributor Author

egberts commented Feb 4, 2016

While I am doing a deep digging into the tb_find_slow_x86_64/tb_find_fast_x86-64 using 10,000-instruction GDB reverse debugging session.... how far-planned is the QEMU 2.5 doing?

@aquynh
Copy link
Member

aquynh commented Feb 5, 2016

i am still working on syncing with 2.5, focusing on ARM first. this will not be fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egberts @aquynh