Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip invalid outline nodes #101

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Skip invalid outline nodes #101

merged 2 commits into from
Jun 27, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jun 27, 2019

Addresses #65


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #101 into development will decrease coverage by 5.38%.
The diff coverage is 31.25%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #101      +/-   ##
===============================================
- Coverage        62.32%   56.94%   -5.39%     
===============================================
  Files              154      154              
  Lines            28014    28029      +15     
===============================================
- Hits             17459    15960    -1499     
- Misses           10169    10185      +16     
- Partials           386     1884    +1498
Impacted Files Coverage Δ
model/writer.go 75.07% <0%> (-5.56%) ⬇️
model/outlines.go 62.59% <100%> (-7.78%) ⬇️
model/reader.go 49.41% <28.57%> (-15.65%) ⬇️
internal/e2etest/utils.go 60% <0%> (-20%) ⬇️
ps/exec.go 62.96% <0%> (-18.52%) ⬇️
core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
model/signature_handler.go 55.04% <0%> (-15.6%) ⬇️
ps/operations.go 53.45% <0%> (-13.68%) ⬇️
core/stream.go 31.08% <0%> (-13.52%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5989ea...5442d4f. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth added this to the v3.0.3 milestone Jun 27, 2019
@gunnsth gunnsth merged commit 13e08e0 into unidoc:development Jun 27, 2019
@adrg adrg deleted the skip-invalid-outline-nodes branch June 29, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants