Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CalRGB -> RGB image conversion. #103

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

peterwilliams97
Copy link
Contributor

@peterwilliams97 peterwilliams97 commented Jun 28, 2019

Fixed what was probably a typo. We noticed this when doing grayscale conversion.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         154      154           
  Lines       27985    27985           
=======================================
  Hits        15398    15398           
  Misses      10764    10764           
  Partials     1823     1823
Impacted Files Coverage Δ
model/colorspace.go 20.52% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d7020...8f2c568. Read the comment docs.

@gunnsth gunnsth changed the base branch from master to development July 2, 2019 19:32
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 3de3705 into unidoc:development Jul 3, 2019
@peterwilliams97 peterwilliams97 deleted the calrgb branch May 24, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants