Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources of blocks created from pages to the output page resources #104

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add resources of blocks created from pages to the output page resources #104

merged 1 commit into from
Jul 2, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jul 2, 2019

Copies page level resources (e.g. colorspaces) to the destination page. Necessary for blocks created from pages, which have resources which are not referenced in the block contents.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #104 into development will increase coverage by 0.01%.
The diff coverage is 61.53%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #104      +/-   ##
===============================================
+ Coverage        56.94%   56.95%   +0.01%     
===============================================
  Files              154      154              
  Lines            28029    28042      +13     
===============================================
+ Hits             15960    15972      +12     
+ Misses           10185    10183       -2     
- Partials          1884     1887       +3
Impacted Files Coverage Δ
creator/block.go 66.76% <61.53%> (-0.22%) ⬇️
model/resources.go 59.51% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e08e0...6b13044. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 9539b4e into unidoc:development Jul 2, 2019
@adrg adrg deleted the creator-page-resources branch July 3, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants