Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary allocations when converting gray scale image to RGB #117

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Avoid unnecessary allocations when converting gray scale image to RGB #117

merged 1 commit into from
Jul 10, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jul 10, 2019 •
edited by gunnsth
Loading

Related to #7

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 10, 2019 •
edited
Loading

Codecov Report

Merging #117 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #117      +/-   ##
===============================================
+ Coverage        56.95%   56.95%   +<.01%     
===============================================
  Files              154      154              
  Lines            28044    28045       +1     
===============================================
+ Hits             15972    15973       +1     
  Misses           10185    10185              
  Partials          1887     1887
Impacted Files Coverage Δ
model/colorspace.go 20.58% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4fe8c...18dd2f7. Read the comment docs.

@adrg adrg mentioned this pull request Jul 10, 2019
Closed
gunnsth
gunnsth approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit e68b7c6 into unidoc:development Jul 10, 2019
@adrg adrg deleted the image-to-rgb-optimize branch July 11, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth