Optimize: Use original if smaller than "compressed" #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the original image rather than the "optimized" image if the original was smaller.
adrg
reviewed
Jul 11, 2019
model/optimize/image.go
Outdated
| newStream.PdfObjectDictionary.Set(core.PdfObjectName("Length"), &ln) | ||
| replaceTable[stream] = newStream | ||
| images[index].Stream = newStream | ||
| if int64(len(streamData)) < img.OrigSize { |
There was a problem hiding this comment.
The new OrigSize field does not seem necessary as it can be obtained here. Also using continue here does seem suitable instead of adding an additional indentation level to that code block. Maybe we could also add a Debug() log message before continue in order to observe the cases in which this scenario occurs.
originalSize := len(stream.Stream)
if originalSize < len(streamData) {
continue
}
There was a problem hiding this comment.
Good point, will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #51.
This change is