Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading improvements #131

Merged
merged 4 commits into from
Jul 24, 2019

Conversation

gunnsth
Copy link
Contributor

@gunnsth gunnsth commented Jul 23, 2019

Addresses #130

  • Removed redundancy regarding resolving references in the reader
  • Simplified resolving objects in the writer - Only one call to core.ResolveReferencesDeep and using traversal cache to avoid repetition.
  • Fixes various issues
  • Also merged in master to get updated version etc

This change is Reviewable

@gunnsth gunnsth requested a review from adrg July 23, 2019 20:19
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #131 into development will decrease coverage by 0.04%.
The diff coverage is 72.22%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #131      +/-   ##
===============================================
- Coverage        56.24%   56.19%   -0.05%     
===============================================
  Files              187      187              
  Lines            33668    33614      -54     
===============================================
- Hits             18936    18890      -46     
  Misses           12305    12305              
+ Partials          2427     2419       -8
Impacted Files Coverage Δ
core/primitives.go 78.15% <100%> (ø) ⬆️
model/reader.go 44.7% <100%> (-4.71%) ⬇️
model/resources.go 58.7% <100%> (ø) ⬆️
model/page.go 52.23% <50%> (ø) ⬆️
model/writer.go 75.67% <69.23%> (+0.25%) ⬆️
core/utils.go 38.62% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c32554...769667b. Read the comment docs.

@gunnsth gunnsth force-pushed the dev-lazyload-improvements branch from 2e29ec2 to 769667b Compare July 24, 2019 20:29
@gunnsth gunnsth merged commit d2e7eda into unidoc:development Jul 24, 2019
@gunnsth gunnsth deleted the dev-lazyload-improvements branch July 24, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants