Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing resource dict when generating field appearance #135

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Check for missing resource dict when generating field appearance #135

merged 1 commit into from
Jul 31, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jul 31, 2019

Addresses #134


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #135 into development will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #135   +/-   ##
============================================
  Coverage        56.19%   56.19%           
============================================
  Files              187      187           
  Lines            33614    33614           
============================================
  Hits             18890    18890           
  Misses           12305    12305           
  Partials          2419     2419
Impacted Files Coverage Δ
annotator/field_appearance.go 50.62% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e7eda...2ba9e49. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit f1738ac into unidoc:development Jul 31, 2019
@adrg adrg deleted the field-appearance-missing-dr branch August 2, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants