Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PageText.sortPosition() sort order deterministic. #153

Merged
merged 9 commits into from
Aug 29, 2019

Conversation

peterwilliams97
Copy link
Contributor

@peterwilliams97 peterwilliams97 commented Aug 23, 2019

This is a fix for #152

The sort order is now deterministic and the ordering is explained in the source code.

A test case shows how the sorting works.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (development@2d20058). Click here to learn what that means.
The diff coverage is 89.47%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #153   +/-   ##
==============================================
  Coverage               ?   57.14%           
==============================================
  Files                  ?      187           
  Lines                  ?    33719           
  Branches               ?        0           
==============================================
  Hits                   ?    19270           
  Misses                 ?    11954           
  Partials               ?     2495
Impacted Files Coverage Δ
extractor/text.go 65.48% <89.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d20058...6471326. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me like the previous algorithm should work with small change. That one is preferable due to its simplicity. If that is not the case, the rationale for the added complexity should be clarified.

extractor/text.go Show resolved Hide resolved
extractor/text.go Outdated Show resolved Hide resolved
extractor/text.go Outdated Show resolved Hide resolved
extractor/text.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants