Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse signature certificate arrays on signature validation #175

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Parse signature certificate arrays on signature validation #175

merged 1 commit into from
Sep 26, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Sep 26, 2019

Addresses #174


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #175 into development will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #175      +/-   ##
===============================================
- Coverage        57.55%   57.52%   -0.03%     
===============================================
  Files              189      189              
  Lines            34413    34430      +17     
===============================================
  Hits             19806    19806              
- Misses           12059    12076      +17     
  Partials          2548     2548
Impacted Files Coverage Δ
model/sighandler/sighandler_pkcs7.go 52.87% <0%> (-8.46%) ⬇️
model/sighandler/sighandler_rsa_sha1.go 4.54% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6d448...0bd31c8. Read the comment docs.

@gunnsth gunnsth merged commit b063d02 into unidoc:development Sep 26, 2019
@adrg adrg deleted the signature-certificate-array branch September 30, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants