Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy action of annotation #176

Merged
merged 8 commits into from
Oct 4, 2019
Merged

Copy action of annotation #176

merged 8 commits into from
Oct 4, 2019

Conversation

becoded
Copy link
Contributor

@becoded becoded commented Oct 3, 2019 •
edited by gunnsth
Loading

  • Bugfix annotation action wasn't copied completely resulting in a missing action
  • Allow to set annotations with any action

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 3, 2019 •
edited
Loading

Codecov Report

Merging #176 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   57.55%   57.57%   +0.01%     
==========================================
  Files         189      189              
  Lines       34412    34416       +4     
==========================================
+ Hits        19805    19814       +9     
+ Misses      12059    12055       -4     
+ Partials     2548     2547       -1
Impacted Files Coverage Δ
creator/text_chunk.go 85.36% <50%> (-3.83%) ⬇️
model/annotations.go 22.2% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ae7e2...2995ee5. Read the comment docs.

adrg
adrg reviewed Oct 4, 2019
View reviewed changes
Copy link
Collaborator

@adrg adrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I left two observations to consider.

go.mod Outdated Show resolved Hide resolved
creator/text_chunk.go Outdated Show resolved Hide resolved
becoded added 2 commits October 4, 2019 21:03
@becoded
Update text_chunk.go
6b2b46b 
Add dot to comment
@becoded
Update go.mod
2995ee5 
Undo unwanted change
@gunnsth gunnsth changed the base branch from master to development October 4, 2019 19:40
@gunnsth gunnsth merged commit b7dc677 into unidoc:development Oct 4, 2019
@gunnsth gunnsth mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrg adrg adrg left review comments

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@becoded @gunnsth @adrg