Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve TOC line components style properties when setting links #202

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Preserve TOC line components style properties when setting links #202

merged 2 commits into from
Nov 26, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Nov 26, 2019

Related to #193


This change is Reviewable

@adrg adrg changed the title Preserve TOC line component style properties when setting links Preserve TOC line component styles properties when setting links Nov 26, 2019
@adrg adrg changed the title Preserve TOC line component styles properties when setting links Preserve TOC line component style properties when setting links Nov 26, 2019
@adrg adrg changed the title Preserve TOC line component style properties when setting links Preserve TOC line components style properties when setting links Nov 26, 2019
@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #202 into development will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #202      +/-   ##
===============================================
- Coverage        57.52%   57.51%   -0.01%     
===============================================
  Files              189      189              
  Lines            34462    34466       +4     
===============================================
- Hits             19824    19823       -1     
- Misses           12086    12091       +5     
  Partials          2552     2552
Impacted Files Coverage Δ
creator/toc_line.go 70.76% <100%> (-3.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a81d7...146f12a. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 1e26aa8 into unidoc:development Nov 26, 2019
@adrg adrg deleted the toc-improvements branch November 26, 2019 22:41
@gunnsth gunnsth added this to the v3.3.1 milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants