Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utf-16 encoding for serializing outline item titles #223

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Use utf-16 encoding for serializing outline item titles #223

merged 1 commit into from
Jan 13, 2020

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jan 13, 2020 •
edited by gunnsth
Loading

Addresses comment on issue #193

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #223 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #223   +/-   ##
============================================
  Coverage        57.48%   57.48%           
============================================
  Files              190      190           
  Lines            34488    34488           
============================================
  Hits             19827    19827           
  Misses           12109    12109           
  Partials          2552     2552
Impacted Files Coverage Δ
model/outline.go 85.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9616ff...3353053. Read the comment docs.

gunnsth
gunnsth approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit f4d4d05 into unidoc:development Jan 13, 2020
@gunnsth gunnsth mentioned this pull request Jan 13, 2020
Closed
@adrg adrg deleted the outline-items-utf16 branch January 14, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth