Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chapter component SetShowNumbering method #224

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fix Chapter component SetShowNumbering method #224

merged 1 commit into from
Jan 13, 2020

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jan 13, 2020 •
edited by gunnsth
Loading

This change is Reviewable

@adrg adrg changed the base branch from master to development January 13, 2020 19:55
@codecov
Copy link

codecov bot commented Jan 13, 2020 •
edited
Loading

Codecov Report

Merging #224 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #224      +/-   ##
===============================================
- Coverage        57.48%   57.48%   -0.01%     
===============================================
  Files              190      190              
  Lines            34488    34489       +1     
===============================================
  Hits             19827    19827              
- Misses           12109    12110       +1     
  Partials          2552     2552
Impacted Files Coverage Δ
creator/chapters.go 77.19% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9616ff...b686713. Read the comment docs.

gunnsth
gunnsth approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit c7c85bf into unidoc:development Jan 13, 2020
@adrg adrg deleted the chapter-set-numbering branch January 14, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth