Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to stop seeking when reach beginning of file #254

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

gunnsth
Copy link
Contributor

@gunnsth gunnsth commented Feb 11, 2020

This change is Reviewable

@gunnsth gunnsth requested a review from adrg February 11, 2020 12:06
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #254 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #254   +/-   ##
============================================
  Coverage        53.97%   53.97%           
============================================
  Files              192      192           
  Lines            36853    36853           
============================================
  Hits             19892    19892           
  Misses           14418    14418           
  Partials          2543     2543
Impacted Files Coverage Δ
core/parser.go 67.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdee057...594c515. Read the comment docs.

@gunnsth gunnsth force-pushed the dev-fix-eof-parsing-bug branch from adcf703 to f69b3b2 Compare February 11, 2020 19:12
@gunnsth gunnsth force-pushed the dev-fix-eof-parsing-bug branch from f69b3b2 to da431a5 Compare February 11, 2020 19:15
@gunnsth gunnsth merged commit fd4f4b0 into unidoc:development Feb 11, 2020
@gunnsth gunnsth deleted the dev-fix-eof-parsing-bug branch February 11, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant