-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed PdfColorspaceSpecialIndexed.ImageToRGB() #259
Conversation
Codecov Report
@@ Coverage Diff @@
## development #259 +/- ##
===============================================
+ Coverage 54.11% 59.09% +4.98%
===============================================
Files 192 192
Lines 36884 36884
===============================================
+ Hits 19958 21795 +1837
+ Misses 14378 12318 -2060
- Partials 2548 2771 +223
Continue to review full report at Codecov.
|
…k the base cs can have <1 cpts.
Fix hash for PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Add testfile from unipdf#258
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #258 which has a PDF file that shows the problem.
I fixed the indexing.
This fix will fail for indexes over colorspaces for which BitsPerComponent ≠8
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)