Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PdfColorspaceSpecialIndexed.ImageToRGB() #259

Merged
merged 10 commits into from
Feb 26, 2020

Conversation

peterwilliams97
Copy link
Contributor

@peterwilliams97 peterwilliams97 commented Feb 19, 2020

Fixes #258 which has a PDF file that shows the problem.

I fixed the indexing.

This fix will fail for indexes over colorspaces for which BitsPerComponent ≠8


This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #259 into development will increase coverage by 4.98%.
The diff coverage is 77.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #259      +/-   ##
===============================================
+ Coverage        54.11%   59.09%   +4.98%     
===============================================
  Files              192      192              
  Lines            36884    36884              
===============================================
+ Hits             19958    21795    +1837     
+ Misses           14378    12318    -2060     
- Partials          2548     2771     +223
Impacted Files Coverage Δ
model/colorspace.go 27.64% <77.77%> (+16.72%) ⬆️
internal/jbig2/segments/text-region.go 46.85% <0%> (+0.26%) ⬆️
internal/jbig2/segments/symbol-dictionary.go 50.54% <0%> (+0.3%) ⬆️
model/writer.go 75.67% <0%> (+0.42%) ⬆️
internal/jbig2/segments/generic-region.go 47.66% <0%> (+1.35%) ⬆️
fdf/parser.go 40.27% <0%> (+1.38%) ⬆️
internal/jbig2/page.go 31.21% <0%> (+1.46%) ⬆️
model/reader.go 46.41% <0%> (+1.67%) ⬆️
contentstream/contentstream.go 76.36% <0%> (+1.81%) ⬆️
core/primitives.go 78.75% <0%> (+2.4%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de5fe6...d1c7d00. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

model/colorspace.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit e056c0e into unidoc:development Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants