feat: Add Xen support #1240
Merged
feat: Add Xen support #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreistan26
commented
Feb 21, 2024
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
f32e678 to
9b5e55a
Compare
andreistan26
changed the title
xen support for kraftkitXen support
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
4726be4 to
c67465b
Compare
craciunoiuc
requested changes
Apr 16, 2024
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
cb8812c to
96a6886
Compare
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
029891f to
08c224c
Compare
craciunoiuc
previously requested changes
May 8, 2024
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
77bcc05 to
53b93b4
Compare
|
Hey @andreistan26 any new updates here? |
Will finish it up this week |
|
sure thing, no hurry, just wanted to get a status update |
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
6deb6e0 to
c9ecb1b
Compare
|
Can you also add this? thanks: diff --git a/Makefile b/Makefile
index 2b5d0ac0..18f88386 100644
--- a/Makefile
+++ b/Makefile
@@ -272,6 +272,7 @@ buildenv-myself-full: ## OCI image containing the build environment for KraftKit
buildenv-myself: ## OCI image containing KraftKit binaries.
buildenv-qemu: ## OCI image containing a Unikraft-centric build of QEMU.
buildenv-github-action: ## OCI image used when building Unikraft unikernels in GitHub Actions.
+buildenv-xen: ## OCI image containing a Unikraft-centric build of Xen.
tools: ## Build all tools.
kraft: ## The kraft binary.
runu: ## The runu binary. |
|
Hey, how is this going @nderjung should we get to this now and maybe try to get an initial version merged? @andreistan26 can you do a rebase of this if you're not too busy? thanks |
nderjung
approved these changes
Jan 30, 2025
nderjung
reviewed
Feb 5, 2025
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
baedc00 to
43a56e4
Compare
nderjung
requested changes
Feb 7, 2025
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
In the case of Xen, on fast applications, the logs would have been called when the machine was already in the exit state. Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
nderjung
approved these changes
Feb 7, 2025
nderjung
dismissed
craciunoiuc’s stale review
All requests have now been incorporated and review state is stale.
|
Just wanted to chime in and say congrats, this is great news for the Xen Project 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
GitHub-Closes: #990