lib/posix-*: Remove hard dependency on posix-fdtab #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/lib
razvand
requested review from
andreistan26,
flpostolache and
robertZamfir601
and removed request for
a team
This change makes posix-fdtab no longer a hard dependency of posix-eventfd, allowing non-fd parts of its functionality to work without the former selected. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change makes posix-fdtab no longer a hard dependency of posix-pipe, allowing non-fd parts of its functionality to work without the former selected. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change makes posix-fdtab no longer a hard dependency of posix-timerfd, allowing non-fd parts of its functionality to work without the former selected. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change makes posix-fdtab no longer a hard dependency of posix-socket, allowing socket operations using the internal API without needing a userspace-visible fdtab. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change removes posix-fdtab as a hard dependency to posix-tty, allowing the use of the latter without a userspace-visible fd table. The functionality to open file descriptors 0, 1, and 2 at boot remains dependent on posix-fdtab. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/posix-nofdtab
branch
from
848847a
to
3eeabed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This changeset removes
posix-fdtabas a hard dependency from allposix-*libraries that provide file implementations.This improves modularity, allowing for files to be used internally without exposing a userspace-visible file descriptor, nor requiring a file descriptor table at all.
Naturally, support for file-specific binary syscalls continues to require fdtab, as file descriptors are the only interface for userspace to pass file references to the kernel.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
N/A