fix(ucs01): pass ics20 ack directly

Signed-off-by: aeryz <abdullaheryz@protonmail.com>
unionlabs · Jun 10, 2024 · da67107 · da67107
1 parent 5f33dbd
commit da67107
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cosmwasm/ucs01-relay-api/src/types.rs b/cosmwasm/ucs01-relay-api/src/types.rs
@@ -332,8 +332,8 @@ impl TryFrom<Binary> for Ics20Ack {
 impl From<Ics20Ack> for GenericAck {
     fn from(value: Ics20Ack) -> Self {
         match value {
-            Ics20Ack::Result(err) => Ok(err),
-            Ics20Ack::Error(err) => Err(err.into_bytes().into()),
+            Ics20Ack::Result(_) => Ok(value.try_into().unwrap()),
+            Ics20Ack::Error(_) => Err(value.try_into().unwrap()),
         }
     }
 }

diff --git a/cosmwasm/ucs01-relay/src/protocol.rs b/cosmwasm/ucs01-relay/src/protocol.rs
@@ -729,7 +729,7 @@ impl<'a> TransferProtocol for Ics20Protocol<'a> {
         match foreign_protocol {
             Ucs01Protocol::VERSION => Ok(match ack {
                 Ok(_) => Ucs01Protocol::ack_success(),
-                Err(e) => Ucs01Protocol::ack_failure(e.to_string()),
+                Err(_) => Ucs01Protocol::ack_failure("".into()),
             }
             .into()),
             Ics20Protocol::VERSION => Ok(ack),