Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide channel and port id when calling get_denom_address #1299

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: provide channel and port id when calling get_denom_address #1299

merged 2 commits into from
Feb 7, 2024

Conversation

PoisonPhang
Copy link
Contributor

  • Updates the Zerg config to accept port which is used when calling get_denom_address
  • Updates ucli to require channel and port ID when querying ucs01 balances

@PoisonPhang PoisonPhang self-assigned this Feb 7, 2024
@PoisonPhang PoisonPhang linked an issue Feb 7, 2024 that may be closed by this pull request
ucli and zerg need to update their usage of get_denom_address #1296
Closed
@PoisonPhang PoisonPhang marked this pull request as ready for review February 7, 2024 16:20
@PoisonPhang PoisonPhang merged commit 5ddef39 into main Feb 7, 2024
99 checks passed
@PoisonPhang PoisonPhang deleted the 1296-ucli-and-zerg-need-to-update-their-usage-of-get_denom_address branch February 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluelo benluelo benluelo approved these changes

Assignees

@PoisonPhang PoisonPhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ucli and zerg need to update their usage of get_denom_address
2 participants
@PoisonPhang @benluelo