Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable rust-proto-check in ci #1898

Merged
merged 5 commits into from
May 13, 2024
Merged

fix: disable rust-proto-check in ci #1898

merged 5 commits into from
May 13, 2024

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented May 11, 2024

#1436 was merged despite the test it added not actually being ran by CI
This has prevented the CI test suit from running completely since.

This didn't trigger the workflow to have a non-zero exit code as the eval commands were spawned asynchronously. Their stderr and exit codes were disregarded while what did stream from their stdout was captured by files used to continue the rest of the workflow.

These commands in unionlabs/workflows should be ran in a way that their exit status is reflected in the parent and the currently failing test that are in main should be fixed.

The following 13 enabled test are currently failing:

  • .#checks.x86_64-linux.arbitrum-light-client-tests
  • .#checks.x86_64-linux.biome-lint
  • .#checks.x86_64-linux.cometbls-light-client-tests
  • .#checks.x86_64-linux.ethereum-light-client-mainnet-tests
  • .#checks.x86_64-linux.ethereum-light-client-minimal-tests
  • .#checks.x86_64-linux.ethereum-verifier-clippy
  • .#checks.x86_64-linux.ethereum-verifier-tests
  • .#checks.x86_64-linux.go-staticcheck
  • .#checks.x86_64-linux.scroll-light-client-tests
  • .#checks.x86_64-linux.tendermint-light-client-tests
  • .#checks.x86_64-linux.ucs00-pingpong-tests
  • .#checks.x86_64-linux.ucs01-relay-tests
  • .#checks.x86_64-linux.ucs02-nft-tests

@PoisonPhang PoisonPhang merged commit 83eae9d into main May 13, 2024
29 checks passed
@PoisonPhang PoisonPhang deleted the disable-broken-test branch May 13, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants