Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hubble): ignore clients without client_id #2041

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

qlp
Copy link
Contributor

@qlp qlp commented Jun 5, 2024

Hubble can't handle non-existent client_ids

Jun 05 05:52:30 hubble hubble-systemd[2198811]: The application panicked (crashed).
Jun 05 05:52:30 hubble hubble-systemd[2198811]: Message:  called `Option::unwrap()` on a `None` value
Jun 05 05:52:30 hubble hubble-systemd[2198811]: Location: hubble/src/chain_id_query.rs:67
Jun 05 05:52:30 hubble hubble-systemd[2198811]: Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Jun 05 05:52:30 hubble hubble-systemd[2198811]: Run with RUST_BACKTRACE=full to include source snippets.
Jun 05 05:52:30 hubble hubble-systemd[2198811]: Error:
Jun 05 05:52:30 hubble hubble-systemd[2198811]:    0: task 58 panicked
Jun 05 05:52:30 hubble hubble-systemd[2198811]: Location:
Jun 05 05:52:30 hubble hubble-systemd[2198811]:    hubble/src/main.rs:98

this query lists them:

SELECT
	*
FROM
	V0_COSMOS.CREATE_CLIENT
WHERE
	CLIENT_ID IS NULL

KaiserKarel
KaiserKarel previously approved these changes Jun 5, 2024
cor
cor previously approved these changes Jun 5, 2024
fix(hubble): ignore clients without client_id
@qlp qlp dismissed stale reviews from cor and KaiserKarel via de9563d June 5, 2024 16:58
@qlp qlp force-pushed the hubble-ignore-clients-without-id branch from e4802ad to de9563d Compare June 5, 2024 16:58
@qlp qlp merged commit 9eb0972 into main Jun 5, 2024
39 checks passed
@qlp qlp deleted the hubble-ignore-clients-without-id branch June 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants