Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ics008-wasm-client library (closes #515) #581

Merged
merged 6 commits into from
Sep 4, 2023
Merged

implement ics008-wasm-client library (closes #515) #581

merged 6 commits into from
Sep 4, 2023

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Aug 30, 2023 •
edited
Loading

Implements #515

The purpose of the library is gathering common things to wasm in a single library and also restricting the contracts to supporting predefined execute messages and queries since this is not ordinary cosmwasm and contracts are only meant to implement specific endpoints.

Tasks:

  • Implement `ics008-wasm-client``
  • Use it on ethereum-light-client
  • Use it on cometbls-light-client

@aeryz aeryz marked this pull request as ready for review August 30, 2023 16:16
@aeryz aeryz force-pushed the 515-wasm-lc-library branch 2 times, most recently from 4417168 to 658e432 Compare August 30, 2023 16:24
@aeryz aeryz requested review from benluelo and hussein-aitlahcen and removed request for benluelo August 30, 2023 16:25
benluelo
benluelo reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction, just some a few comments

lib/ics-008-wasm-client/src/ibc_client.rs Outdated Show resolved Hide resolved
lib/ics-008-wasm-client/src/ibc_client.rs Outdated Show resolved Hide resolved
light-clients/cometbls-light-client/src/client.rs Outdated Show resolved Hide resolved
light-clients/ethereum-light-client/src/client.rs Outdated Show resolved Hide resolved
lib/ics-008-wasm-client/src/lib.rs Outdated Show resolved Hide resolved
lib/ics-008-wasm-client/src/lib.rs Outdated Show resolved Hide resolved
@aeryz aeryz force-pushed the 515-wasm-lc-library branch 2 times, most recently from 6299663 to 1a1877d Compare August 31, 2023 08:01
@aeryz aeryz force-pushed the 515-wasm-lc-library branch from 1a1877d to 7d11404 Compare September 4, 2023 07:19
aeryz added 5 commits September 4, 2023 10:20
@aeryz
feat(ics008): introduce IBCClient
0f18277 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(ics008): implement generic storage utils
4c25779 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(ethereum-lc): use ics008-wasm-client
de64850 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(cometbls-lc): use ics008-wasm-client
4ac6103 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(ics008-wasm-client): finalize the api
29709b2 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
fix(ics008): make sure we are encoding snake case
337a43e 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz force-pushed the 515-wasm-lc-library branch from 7d11404 to 337a43e Compare September 4, 2023 08:27
@aeryz
Copy link
Contributor Author

aeryz commented Sep 4, 2023

NOTE: I tested out the local e2e-setup with handshake enabled, and ran ping pongs, no problem seems to be exist.

@aeryz aeryz merged commit 9b3c4bb into main Sep 4, 2023
@aeryz aeryz deleted the 515-wasm-lc-library branch September 4, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussein-aitlahcen hussein-aitlahcen hussein-aitlahcen approved these changes

@benluelo benluelo Awaiting requested review from benluelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aeryz @hussein-aitlahcen @benluelo