Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(voyager): use the correct sync committee during the update (closes #763) #764

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix(voyager): use the correct sync committee during the update (closes #763) #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion light-clients/ethereum-light-client/src/consensus_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl<C: ChainSpec> TrustedConsensusState<C> {
// We are making sure that the given trusted sync committee actually matches
// the sync committee that we stored
if active_sync_committee != given_committee.aggregate_pubkey
&& given_committee.aggregate_pubkey != aggregate_public_key
|| given_committee.aggregate_pubkey != aggregate_public_key
{
Err(Error::InvalidSyncCommittee)
} else {
Expand Down
8 changes: 2 additions & 6 deletions voyager/src/chain/evm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,7 @@ where
chain_id,
data: Fetch::LightClientSpecific(LightClientSpecificFetch(
CometblsFetchMsg::FetchBootstrap(FetchBootstrap {
slot: currently_trusted_slot,
slot: light_client_update.attested_header.beacon.slot,
__marker: PhantomData,
}),
)),
Expand Down Expand Up @@ -1447,10 +1447,7 @@ where
hlist_pat![
Identified {
chain_id: bootstrap_chain_id,
data: BootstrapData {
slot: bootstrap_slot,
bootstrap
}
data: BootstrapData { slot, bootstrap }
},
Identified {
chain_id: account_update_chain_id,
Expand All @@ -1473,7 +1470,6 @@ where
assert_eq!(bootstrap_chain_id, account_update_chain_id);
assert_eq!(chain_id, account_update_chain_id);
assert_eq!(chain_id, beacon_api_chain_id);
assert_eq!(bootstrap_slot, currently_trusted_slot);

let header = wasm::header::Header {
height: Height {
Expand Down