Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scaffold top-level errors #791

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: scaffold top-level errors #791

merged 1 commit into from
Oct 11, 2023

Conversation

benluelo
Copy link
Contributor

@benluelo benluelo commented Oct 11, 2023 •
edited
Loading

also started working on tendermint json serde, will pick up at a later date as it is quite a mess

cor
cor approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@cor cor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benluelo benluelo merged commit 9c80ca3 into main Oct 11, 2023
141 of 142 checks passed
@benluelo benluelo deleted the voyager-error-handling-part-1 branch October 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor cor cor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benluelo @cor