Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(voyager): split messages out into a crate #884

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat(voyager): split messages out into a crate #884

merged 1 commit into from
Nov 3, 2023

Conversation

benluelo
Copy link
Contributor

@benluelo benluelo commented Nov 3, 2023 •
edited
Loading

  • split lightclients into a crate
  • split voyager messages into a crate, with the previously split LightClient trait moved to this crate (pending rename)

@benluelo benluelo force-pushed the move-relayer-msg-to-crate branch from 2176c5f to 7cb4fd4 Compare November 3, 2023 14:49
@benluelo benluelo marked this pull request as ready for review November 3, 2023 14:49
PoisonPhang
PoisonPhang approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@PoisonPhang PoisonPhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@KaiserKarel KaiserKarel changed the title feat(voyager)!: split messages out into a crate feat(voyager): split messages out into a crate Nov 3, 2023
@benluelo benluelo merged commit d3776cd into main Nov 3, 2023
133 of 138 checks passed
@benluelo benluelo deleted the move-relayer-msg-to-crate branch November 3, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoisonPhang PoisonPhang PoisonPhang approved these changes

@hussein-aitlahcen hussein-aitlahcen hussein-aitlahcen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benluelo @hussein-aitlahcen @PoisonPhang