fix: filter_builds not being applied and summaries on zero job runs #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PoisonPhang
commented
Feb 5, 2024
PoisonPhang
commented
- Fixes issue with nightly builds where filter_builds wasn't being applied without eval_target being supplied.
- Fix demonstrated here
- Fixes issue where build summaries triggered an error if there were no jobs queued
- Fix demonstrated here
benluelo
approved these changes
Feb 5, 2024
PoisonPhang
changed the title
PoisonPhang
deleted the
28-build-fails-after-prs-are-successfully-merged
branch
PoisonPhang
added a commit
to unionlabs/union
that referenced
this pull request
Feb 5, 2024
- Fixes issue with nightly builds where `filter_builds` wasn't being applied without `eval_target` being supplied. Closes #1265 - Fix demonstrated [here](https://github.com/unionlabs/union/actions/runs/7786460547/job/21231418919) - Fixes issue where build summaries triggered an error if there were no jobs queued (closes #1261 ) - Fix demonstrated [here](https://github.com/unionlabs/union/actions/runs/7788142685) Needs unionlabs/workflows#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.