Fix diff in months and added tests (#42)

uniplaces · Jun 20, 2018 · 57f1331 · 57f1331
1 parent d1deb18
commit 57f1331
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/carbon.go b/carbon.go
@@ -1209,7 +1209,7 @@ func (c *Carbon) DiffInMonths(carb *Carbon, abs bool) int64 {
 		}
 
 		diffYr := c.Year() - carb.Year()
-		if diffYr > 1 {
+		if math.Abs(float64(diffYr)) > 1 {
 			diff := c.DiffInYears(carb, abs)*monthsPerYear + m
 
 			return absValue(abs, diff)

diff --git a/carbon_test.go b/carbon_test.go
@@ -1958,6 +1958,13 @@ func TestDiffInMonthsMoreThanOneYear(t *testing.T) {
 	assert.EqualValues(t, 13, t1.DiffInMonths(t2, true))
 }
 
+func TestDiffInMonthsMoreThanTwoYears(t *testing.T) {
+	t1, _ := Create(2018, time.August, 4, 1, 0, 0, 0, "UTC")
+	t2, _ := Create(2025, time.July, 3, 1, 0, 0, 0, "UTC")
+
+	assert.EqualValues(t, 82, t1.DiffInMonths(t2, true))
+}
+
 func TestDiffInMonthsOneDayDifference(t *testing.T) {
 	t1, _ := Create(2016, time.September, 1, 10, 0, 0, 0, "UTC")
 	t2, _ := Create(2016, time.August, 31, 10, 0, 0, 0, "UTC")