Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fix incorrect diff in months #74

Merged
merged 2 commits into from
Apr 16, 2022
Merged

[RFC] Fix incorrect diff in months #74

merged 2 commits into from
Apr 16, 2022

Conversation

rntdrts
Copy link
Contributor

@rntdrts rntdrts commented Apr 16, 2022

Fixes #59
Fixes #60

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #74 (f4db8be) into master (ce063dd) will increase coverage by 0.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.11%   90.10%   +0.99%     
==========================================
  Files           3        3              
  Lines         634      637       +3     
==========================================
+ Hits          565      574       +9     
+ Misses         44       39       -5     
+ Partials       25       24       -1     
Impacted Files Coverage Δ
carbon.go 91.18% <100.00%> (+0.71%) ⬆️
translator.go 65.51% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33bdc51...f4db8be. Read the comment docs.

@rntdrts rntdrts force-pushed the fix-diff-months-calc branch from 79f4df2 to f4db8be Compare April 16, 2022 11:01
@rntdrts rntdrts merged commit a000e35 into master Apr 16, 2022
@rntdrts rntdrts deleted the fix-diff-months-calc branch April 16, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect DiffInMonths calculation
2 participants